Modify PartnerInviteService to use Partner name as name to use for invite #4112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the reviewer's context -- after comparing the partner and primary contact emails in prod, I found that nearly 50% were different, where provided. The original ask, was, therefore, misguided. We still want to have a name on the partner user, but having that name be the partner name will provide us that benefit, while maintaining a proper distinction between the partner and the primary contact. |
dorner
approved these changes
Feb 16, 2024
|
Thanks! |
|
Hurrah! |
|
@jp524: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4036.
Description
This PR uses the Partner name given in the new partner form as the User's name during the partner invite process.
Type of change
How Has This Been Tested?
Modified
spec/services/partner_invite_service_spec.rb.Screenshots