Fix flaky tests #4125
Merged
Fix flaky tests #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dorner: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for the flaky tests seems to have been our use of select2. During initialization, select2 creates options and appends them to the select div. However, there is a point where the option exists but isn't appended. This causes Cuprite not to be able to select it because it has no parent node.
I added a
select2helper which should ease us in selecting these in the future. We can make use of it for any other flaky tests that crop up.I also fixed an issue with the
turbo_controllerwhere it would crash on error because it's trying to access a property of something that doesn't exist.