Refactor request spec test #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubyforgood#4135 When individuals requests were submitted with incorrect values the error page did not preserve correct or incorrect inputs. This was happening because the controller created a new request on error. Now the new request will be populated with the items from the failed request. I attempted to reuse the failed request, however, because the individuals request is a wrapper around a family request that behavior was not possible.
This was referenced Mar 1, 2024
elasticspoon
force-pushed
the
refactor-request-spec-test
branch
from
2157438
to
f6d8069
Compare
elasticspoon
commented
Mar 4, 2024
|
@cielf When I was refactoring I noticed that family requests require certain permissions: module Partners
class FamilyRequestsController < BaseController
before_action :verify_partner_is_active
before_action :authorize_verified_partnerswhereas Individual requests don't: module Partners
class FamilyRequestsController < BaseController
no callbacks hereis that intended or an oversight? |
|
From a business p.o.v. you have to be approved before making requests for all three of the different kinds of requests. |
dorner
requested changes
Mar 7, 2024
dorner
approved these changes
Mar 8, 2024
|
Thank you! |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4142
Description
Moves a bunch of behavior from
managing_requests_system_spec.rbto request specs. A lot of what the system test was doing was basically checking input validation, that can be done in requests spec much cheaper.Type of change