Product drives name filter - to list names in alphabetical order #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Mar 1, 2024
| @@ -10,6 +10,8 @@ def index | |||
| .class_filter(filter_params) | |||
| .within_date_range(@selected_date_range) | |||
| .order(start_date: :desc) | |||
| # to be used in the name filter to sort product drives in alpha order | |||
| @product_drives_name_filter = @product_drives.sort_by { |pd| pd.name.downcase } | |||
There was a problem hiding this comment.
Can we rename this to @product_drives_alphabetical? It's a bit more obvious what's inside it.
dorner
approved these changes
Mar 3, 2024
|
@kannans5: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4119
Description
Name filter on Product drives list page should be in alphabetical order, this will be helpful for banks having a long list.
Type of change
How Has This Been Tested?
Browser tests have been modified to test this change.
Screenshots
Before
After