fix(4129): flaky event differ test #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal reproduction command:
rspec ./spec/events/event_differ_spec.rb[1:1] ./spec/models/inventory_item_spec.rb[1:1:1:3] --seed 32476
Crux of the matter is:
```rb
StorageLocation.count + 1 => EventTypes::EventStorageLocation.new(
id: StorageLocation.count + 1,
items: {}
)
```
assumes that there will be 3 storage locations 1, 2, 3. If inventory_item_spec
runs before, it creates a storage location. Thus, count will still be 3
but storage_location3 will have id: 4.
Thus, storage_location3.id => stuff get overridden by StorageLocation.count + 1 => stuff.
By changing the id of the nonexistent location to 0 we achieve the same
test without a dependency on not having storage locations created before
this test runs.
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4129
Minimal reproduction command:
rspec ./spec/events/event_differ_spec.rb[1:1] ./spec/models/inventory_item_spec.rb[1:1:1:3] --seed 32476Crux of the matter is:
assumes that there will be 3 storage locations 1, 2, 3. If
inventory_item_specruns before, it creates a storage location. Thus, count will still be 3 butstorage_location3will have id 4.Thus,
storage_location3.id => stuffgets overridden byStorageLocation.count + 1 => stuff.By changing the id of the nonexistent location to 0 we achieve the same test without a dependency on not having storage locations created before this test runs.
Type of change