fix: empty item request regression #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
force-pushed
the
fix-empty-individual-requests
branch
2 times, most recently
from
13c826b
to
5124a03
Compare
A previous PR by me introduced a regression that made
individuals requests fail with empty attributes.
The mistaken assumption I made was assuming an empty request
would have params family_attrs => 0 => {id: "", value: ""}
In reality they should be nil.
Also introduced a bit of flakiness in the partner_system_spec.
That has been fixed.
elasticspoon
force-pushed
the
fix-empty-individual-requests
branch
from
5124a03
to
41960e3
Compare
dorner
approved these changes
Mar 10, 2024
|
Nice, thanks! |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR by me introduced a regression that made individuals requests fail with empty attributes.
The mistaken assumption I made was assuming an empty request would be:
should be:
This causes
FamilyRequestServiceto fail. This PR fixes the regression.Also
expect { @partner.reload }.to change(@partner, :requestable_items).from([]).to(items_in_category)created order dependent flakiness. That has been fixed.Type of change
How Has This Been Tested?
Request Tests