Remove cocoon #4184
Merged
Remove cocoon #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
force-pushed
the
remove-cocoon
branch
2 times, most recently
from
1f02a5b
to
8964227
Compare
elasticspoon
force-pushed
the
remove-cocoon
branch
6 times, most recently
from
27b1a07
to
9d4478a
Compare
elasticspoon
force-pushed
the
remove-cocoon
branch
3 times, most recently
from
1b369f3
to
3fe1164
Compare
elasticspoon
force-pushed
the
remove-cocoon
branch
from
3fe1164
to
d60ae4c
Compare
Removes all cocoon code. Depends on rubyforgood#4182. Needs to clear precompiled assets to work.
elasticspoon
force-pushed
the
remove-cocoon
branch
from
d60ae4c
to
4b88c86
Compare
dorner
approved these changes
Apr 2, 2024
|
Amazing! |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3556
I am working on several PRs to replace cocoon with existing Stimulus behavior.
This PR depends on 2 other PRs. Specifically this one removes the dependency on Cocoon,previous ones have already replaced cocoon behavior.
About Further Refactoring
After looking at it, I think unless the goal is specifically to remove jquery the code would get more complex by moving stuff like the donations utility javascript to stimulus controllers.
I think it would result in a ton of duplication of setting data-targets in the HTML. Not a big fan, but I am totally open to other ideas on how to further refactor.
Type of change
How Has This Been Tested?
Passes Existing Tests