Ensure random record for organization in seeds #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezus
commented
Mar 21, 2024
| @@ -19,7 +19,7 @@ def random_record(klass) | |||
| end | |||
|
|
|||
| def random_record_for_org(org, klass) | |||
| klass.where(organization: org).limit(1).order(Arel.sql('random()')).first | |||
| klass.where(organization: org).all.sample | |||
There was a problem hiding this comment.
Because we're in fresh-seeding territory and row counts are very low, we went with all.sample which is pretty foolproof.
dorner
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4211.
Description
When seeding donations, we expect between one and five items attached to each donation (each with several hundred quantity). For some reason, the
random_record_for_orgmethod was caching, resulting up to five line items with the same item.This PR just ensures that a fresh record is returned for each line item.
Type of change
How Has This Been Tested?
I've run and re-run the
bin/setupprocess multiple times and ensured the data generated looks correct.Screenshots
Before
After