[4171] Fix issue with storage location resetting on error. #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes my functionality test -- I uncovered a separate pre-existing issue, which is that a new purchase is not defaulting to the organization's default intake location. That is out of scope of this PR, though. |
dorner
approved these changes
Mar 26, 2024
|
All good here too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4171
Description
When creating a new purchase, if a storage location is selected and there's an error during submission, the storage location resets to the first one in the list. This PR addresses this issue by ensuring that the selected storage location remains unchanged in case of an error.
Type of change
How Has This Been Tested?
This change has been tested by creating a new purchase, selecting a storage location, and intentionally causing an error during submission. Upon encountering the error, it was verified that the selected storage location remained unchanged.
Screencast
Screencast.from.23-03-24.11.44.13.PM.IST.webm