refactor: remove item seeding (models easy) #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
changed the title
elasticspoon
changed the title
elasticspoon
force-pushed
the
remove-item-seeding-models-simple-ones
branch
from
e81d32b
to
4e47d1e
Compare
|
@elasticspoon can you rebase this (and the other 2 PRs) off main now that the blocker has been merged? |
elasticspoon
force-pushed
the
remove-item-seeding-models-simple-ones
branch
from
4e47d1e
to
c391513
Compare
elasticspoon
force-pushed
the
remove-item-seeding-models-simple-ones
branch
from
c391513
to
fd658c7
Compare
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4199
This is the model changes that require minimal work. Their behavior does not depend on item seeding.
Lemme know how you feel about the sizes of these PRs. Its not that many lines of code and basically all find and replaces but its a lot of files.
Type of change
How Has This Been Tested?
Passes current suite