refactor: remove item seeding (models med) #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
from
16d65cf
to
9b29eff
Compare
elasticspoon
changed the title
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
from
9b29eff
to
4549e83
Compare
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
from
8578b1f
to
441a770
Compare
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
3 times, most recently
from
585fd3f
to
b238b45
Compare
elasticspoon
commented
May 2, 2024
elasticspoon
commented
May 2, 2024
| end | ||
| # TODO: do negative numbers make sense here? | ||
| # it { should validate_numericality_of(:quota).is_greater_than_or_equal_to(0).allow_nil } | ||
| it { should validate_numericality_of(:quota).allow_nil } |
There was a problem hiding this comment.
do negative numbers make sense here?
it { should validate_numericality_of(:quota).is_greater_than_or_equal_to(0).allow_nil }
There was a problem hiding this comment.
I see no reason you'd have negative quota values. If it doesn't already validate for that, we could make it a GFI.
There was a problem hiding this comment.
It does not so probably a GFI
medium models
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
from
b238b45
to
2846a5f
Compare
dorner
requested changes
May 3, 2024
elasticspoon
force-pushed
the
remove-spec-seeding-med-models
branch
from
05a7500
to
c1b104e
Compare
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4199
This is the model changes that require a bit more work.
There are some refactors with changing validations to shoulda matchers, largely just find and replace.
Also contains all itemizables.
Type of change
How Has This Been Tested?
Passes current suite