Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable editing/reclaiming itemizables with inactive items #4235

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

dorner
Copy link
Collaborator

@dorner dorner commented Mar 29, 2024

Resolves #4226

Description

This disables editing of distributions, purchases and donations that have an inactive item.

image image

@dorner dorner requested a review from cielf March 29, 2024 18:09
@cielf cielf requested a review from awwaiid March 29, 2024 22:37
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice from a functional pov. Thanks!

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and mergeable.

However, perhaps separately -- should there be a model or controller level validation that also prevents this?

@awwaiid awwaiid merged commit 17d91af into main Mar 30, 2024
20 checks passed
@awwaiid awwaiid deleted the 4226-inactive-fixes branch March 30, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inactive items and itemizables -- regarding editing and reclaiming.
3 participants