Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace support link for partners with a message to contact their bank #4279

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

mgriffin
Copy link
Contributor

Resolves #4186

Description

As described in #4186, this PR makes a change to the error message displayed to partners. It removes the support link and replaces it with the name of the Partner's Bank and the email address of that bank.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The existing tests have been modified to reflect the changes in the error message. They now ensure that the name of the Bank and the email address exist in the error message

Screenshots

Before

Screenshot 2024-04-16 at 11 34 01

After

Screenshot 2024-04-16 at 11 20 34

/cc @sampart @kurgol @hharen

Co-authored-by: @sampart <sampart@github.com>
Co-authored-by: @kurgol <kurgol@github.com>
Co-authored-by: @hharen <hharen@github.com>
@mgriffin mgriffin force-pushed the mgriffin/replace-support-link branch from ff64fde to 721e8d1 Compare April 16, 2024 14:06
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good, but tests and lint are both failing on CI.

@mgriffin mgriffin requested a review from dorner April 22, 2024 08:42
@dorner
Copy link
Collaborator

dorner commented Apr 22, 2024

Looks good!

@dorner dorner merged commit e9adb43 into rubyforgood:main Apr 22, 2024
18 of 19 checks passed
@mgriffin mgriffin deleted the mgriffin/replace-support-link branch April 23, 2024 08:29
Copy link
Contributor

@mgriffin: Your PR Replace support link for partners with a message to contact their bank is part of today's Human Essentials production release: 2024.04.28.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the link to the support form for partners.
2 participants