Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox styling #4289

Conversation

Hitin
Copy link

@Hitin Hitin commented Apr 20, 2024

Fix Issue #4286

Description

Previously, the checkboxes mentioned above were being rendered like inputs -- very wide. Also, the checked state was not reflected! This PR makes them render as normal checkboxes, primarily thanks to the removal of the form-control

Screenshots
http://localhost:3000/partners/profile/edit before
SCR-20240420-okjp
http://localhost:3000/partners/profile/edit after
SCR-20240420-olor

http://localhost:3000/partners/families before
SCR-20240420-ojme
http://localhost:3000/partners/families after
image

http://localhost:3000/partners/children before
SCR-20240420-ojby

http://localhost:3000/partners/children after
image

@Hitin Hitin force-pushed the 4286-Restyling-checkboxes-in-partner-areas-part-2 branch from e5b4adf to a03257e Compare April 20, 2024 13:06
@Hitin Hitin force-pushed the 4286-Restyling-checkboxes-in-partner-areas-part-2 branch from a03257e to cfec3d8 Compare April 20, 2024 13:57
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Will wait to merge till after today's release.

@dorner dorner merged commit 13eba1a into rubyforgood:main Apr 21, 2024
19 checks passed
Copy link
Contributor

@Hitin: Your PR Fix checkbox styling is part of today's Human Essentials production release: 2024.04.28.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants