Prevent import of inventory if storage location already has items in it and double importing

[vincent-truong-dev]

Fixes #3687

Partially borrowed from #3696

Description

Importing storage location inventory can have 2 weird behaviours

• If imported in two separate tabs of the same storage location, the inventory is doubled when it should be one import. This isn't handled by the current front end check
• If Import CSV is double clicked, there is double inventory when it should be just one import.

The fix is

• A back end check that redirects to the page with an error if the storage location already has inventory
• Disabling the Import CSV button with a greyed out look and text once clicked.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Double tab issue

1. Make sure a storage location has already been setup
2. Navigate to http://localhost:3000/diaper_bank/storage_locations/<id> to show an individual storage location in both tabs
3. Click `Import Baseline Inventory' in both tabs
4. Upload a sample csv
5. Click Import CSV in both tabs
6. In first tab, see the import is successful
7. In second tab, see error message in screenshot is displayed

Double click issue

1. Make sure a storage location has already been setup
2. Navigate to http://localhost:3000/diaper_bank/storage_locations/<id> to show an individual storage location in one tab
3. Click `Import Baseline Inventory' in
4. Upload a sample csv
5. Try to double click Import CSV in one tab
6. See you can't double click the button as it is disabled and says Importing like in screenshot.

Screenshots

[vincent-truong-dev]

Only thing changed was adding data: { disable_with: "Importing" }, otherwise rearranging the button tag to be in its own line.

Looked into writing a system spec for this but it's near impossible to trigger a double click the way we want . The various double click methods (.click.click, double_click, or using js trigger or execute_script) don't actually let you double click. Neither double clicks results in two backend calls, only once.

[dorner]

I think that's fine - if we are validating this on the backend, that's the most important check. Frontend is more of a nice to have.

[dorner]

We need this to work both with and without event sourcing. Can you use the method empty_inventory?instead to check this? That's works with both.

[dorner]

I think that's fine - if we are validating this on the backend, that's the most important check. Frontend is more of a nice to have.

[cielf]

Hey @vincent-truong-dev - I noticed that rubocop is failing with your latest -- you'll need to address that.

[vincent-truong-dev]

@cielf @dorner all green now. I encountered a transient system spec failure in https://github.com/rubyforgood/human-essentials/actions/runs/8882912643/job/24388616782, worth creating a ticket for?

[cielf]

@cielf @dorner all green now. I encountered a transient system spec failure in https://github.com/rubyforgood/human-essentials/actions/runs/8882912643/job/24388616782, worth creating a ticket for?

Thanks for pointing it out! I'm pretty sure that's the one that PR #4268 is addressing, so no need to create a ticket.

[dorner]

All good!

Rubocop is fixed

[github-actions]

@vincent-truong-dev: Your PR Prevent import of inventory if storage location already has items in it and double importing is part of today's Human Essentials production release: 2024.05.05.
Thank you very much for your contribution!