4294 Disable deleting purchases and donations with inactive items #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Apr 25, 2024
app/views/donations/show.html.erb
Outdated
| <%= delete_button_to donation_path(@donation), { | ||
| size: "md", | ||
| enabled: !@donation.has_inactive_item?, | ||
| confirm: "Are you sure you want to permanently remove this donation?" } if current_user.has_role?(Role::ORG_ADMIN, current_organization) %> |
There was a problem hiding this comment.
This is a pretty hefty statement now - can we break the if into the block format instead of it being at the end of it?
There was a problem hiding this comment.
@dorner Thanks for the suggestion. The change has been made.
… into block format for donations and purchases.
|
@cielf 🤦 Sorry! I missed that! It should be corrected now. |
|
Looks good to me -- @dorner -- if you're happy with the correction to the nitpick, we can merge. |
|
@pshong79: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4294
Description
If a donation or a purchase contains an inactive item, the system is likely to return an error.
Currently, when trying to delete a purchase with inactive items in Production, it is returning an inventory error.
To mitigate this, we should just not allow for deleting a purchase or donation if there are inactive items and display a message instructing the user to make the inactive item active.
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Tested manually
Updated
donations_request_spec.rbandpurchases_request_spec.rbto verify that theDeletebutton isdisabledfor theorganization adminuser.Screenshots
Purchases
Before:
After:
Donations
Before:
After:
