fix(#4297): flaky report spec #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the test to explicitly create all the items needed. This removes flakiness surrounding potential situations where generated items get counted as disposable.
elasticspoon
force-pushed
the
fix-children-report
branch
from
8a22b61
to
61227c9
Compare
dorner
approved these changes
Apr 26, 2024
|
Nice, thanks! |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the test to explicitly create all the items needed. This removes flakiness surrounding potential situations where generated items get counted as disposable.