restoring settings partial in partner profile edit #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
approved these changes
Apr 27, 2024
|
I've put a GFI in the backlog around this. |
|
@cielf: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found an issue on staging where the settings had disappeared from the partner profile edit (from the partner pov)., it appears from #4051. This restores it.
Noting, though, that we should also have a test that this partial is appearing -- since we didn't catch it disappearing through either our functional or technical reviews -- and most partners won't notice that it's gone.
I'm also getting a lot of unrelated failures on my local (11).
Type of change
How Has This Been Tested?
manual check -- went in as verified@example.com and checked that the fields appeared.