Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove item seeding (requests 1) #4325

Merged

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented May 2, 2024

Related to #4199

These changes are all super simple find and replace type fixes in spec/requests.

Type of change

  • Refactor

How Has This Been Tested?

Passes current suite

@elasticspoon elasticspoon changed the title refactor: removed db seeding dependency refactor: remove item seeding (requests 1) May 2, 2024
@elasticspoon elasticspoon force-pushed the remove-spec-seeding-requests-1 branch from b124868 to 907f0f1 Compare May 2, 2024 18:55
find and replace in requests
@elasticspoon elasticspoon force-pushed the remove-spec-seeding-requests-1 branch from 907f0f1 to 5368f4f Compare May 2, 2024 19:21
@elasticspoon elasticspoon marked this pull request as ready for review May 2, 2024 19:33
@elasticspoon elasticspoon mentioned this pull request May 2, 2024
21 tasks
@elasticspoon elasticspoon requested a review from dorner May 2, 2024 19:36
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

let(:user) { create(:user, organization: organization) }
let(:organization_admin) { create(:organization_admin, organization: organization) }

# TODO: should this be testing something?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove this.

@dorner dorner merged commit 6603dd5 into rubyforgood:main May 3, 2024
19 checks passed
Copy link
Contributor

github-actions bot commented May 5, 2024

@elasticspoon: Your PR refactor: remove item seeding (requests 1) is part of today's Human Essentials production release: 2024.05.05.
Thank you very much for your contribution!

@elasticspoon elasticspoon deleted the remove-spec-seeding-requests-1 branch May 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants