Aeisenberg devcontainer updates #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for GitHub Codespaces. It includes a devcontainer configuration that will be used to create a Codespace for this repository. The configuration includes: - Dockerfile: Installs `ruby:dev-3.2-buster` image. When the version of ruby used by this project changes, the Dockerfile should be updated. An attempt to install the correct version of ruby will be done, but it will take a while to download and compile the version. - devcontainer.json: Specifies the configuration for the Codespace. It includes the Dockerfile to use, the extensions to install, and the settings to use. - docker-compose.yml: Specifies the services to run in the Codespace. It includes the `postgres` service. - post-create.sh: Script that runs after the Codespace is created. It optionally installs a new version of ruby, sets up the database, and prepares the environment.
aeisenberg
approved these changes
May 12, 2024
|
Spec fails are unrelated, I'm fixing in main and will merge that in here for a clean bill of health :) |
dorner
approved these changes
May 15, 2024
|
@awwaiid Looks good to me! Any reason to wait on the merge? |
This was referenced May 15, 2024
Closed
|
Nope :) |
|
Thanks for the reviews and getting this pushed through! |
|
@aeisenberg thank you for the contribution! It'll likely take some practice, but I think it could really decrease the barrier-to-entry yet another notch for contributors. |
|
You're very welcome. I hope so. |
|
@awwaiid: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly modified version of #4292 with README and config updates.