737 all controllers i18n revision #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds missing translations to corresponding en.yml - Fixes wrong look ups of translations
kasugaijin
reviewed
Jun 1, 2024
| @@ -26,7 +26,7 @@ def create | |||
| .new_adoption_application.deliver_now | |||
| else | |||
| redirect_to adoptable_pet_path(@pet), | |||
| alert: "Error. Please try again." | |||
| alert: t(".error") | |||
There was a problem hiding this comment.
So this finds the appropriately scoped translation? I have always called the full reference to it and did not know this would work!
There was a problem hiding this comment.
Yes, it's called lazy lookup. Important to notice that it is not ALWAYS suitable. Sometimes we have to use the full path. In tests or module helpers requires `I18n.t("full/path") since the path context is not clear.
ATE I18n rails documentation for this moment🤣
kasugaijin
approved these changes
Jun 1, 2024
kasugaijin
approved these changes
Jun 1, 2024
|
@kasugaijin Once this is merged and I know it's all good I'll work on views so we can close the related issue. |
|
@wandergithub press that green button when you're ready :) |
|
@kasugaijin I don't have permission to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue
#737
✍️ Description
📷 Screenshots/Demos