Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Explain why we don't use HTTPS for github sources
Browse files Browse the repository at this point in the history
There are frequent pull requests proposing this change, which has
already been merged to 2-0-dev.
  • Loading branch information
TimMoore committed Nov 27, 2015
1 parent 437f604 commit 9e055dc
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions lib/bundler/dsl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,19 @@ def method_missing(name, *args)

def add_git_sources
git_source(:github) do |repo_name|
# It would be better to use https instead of the git protocol, but this
# can break deployment of existing locked bundles when switching between
# different versions of Bundler. The change will be made in 2.0, which
# does not guarantee compatibility with the 1.x series.
#
# See https://github.com/bundler/bundler/pull/2569 for discussion
#
# This can be overridden by adding this code to your Gemfiles:
#
# git_source(:github) do |repo_name|
# repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
# "https://github.com/#{repo_name}.git"
# end
repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
"git://github.com/#{repo_name}.git"
end
Expand Down

0 comments on commit 9e055dc

Please sign in to comment.