This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
only parse specs as YAML if they look like YAML files, otherwise fall
back to Ruby evaluation
- Loading branch information
1 parent
e93a399
commit d1b6ced
Showing
1 changed file
with
24 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1b6ced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a pre-release on this?
Can't create a new Rails 4 project on Ruby 2 preview without it.
d1b6ced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just came to the same conclusion as @jroes. Apparently catching SyntaxError doesn't quite cut it any more, Psych::SyntaxError is what is raised. Even better: don't try it to parse it as YAML at all if it doesn't look like YAML...
d1b6ced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d1b6ced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a new ETA for 1.2.2?
d1b6ced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently wrestling with a failing spec that seems to only happen on ruby 1.9.2 and rubygems 1.7. Assuming I manage to get that resolved today, I will then push the new gem.