Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

amend Rake 0.9 support #1196

Merged
merged 1 commit into from May 27, 2011
Merged

amend Rake 0.9 support #1196

merged 1 commit into from May 27, 2011

Conversation

quix
Copy link
Contributor

@quix quix commented May 23, 2011

The original commit for Rake 0.9 support (6c3123a) was problematic: the top level include Rake::DSL pollutes Object with the methods 'task', 'file', etc., which is what Rake 0.9 intended to correct. Also, requiring a private Rake header (dsl_definition.rb) is asking for trouble.

[Update] This pull request passes all working specs.

The relevant section of the Rake's ChangeLog:

* *Incompatible* *change*: Rake DSL commands ('task', 'file', etc.) are
  no longer private methods in Object. If you need to call 'task :xzy' inside
  your class, include Rake::DSL into the class. The DSL is still available at
  the top level scope (via the top level object which extends Rake::DSL).

@quix
Copy link
Contributor Author

quix commented May 25, 2011

Updated above description -- possible spec failure previously mentioned was unrelated.

indirect pushed a commit that referenced this pull request May 27, 2011
@indirect indirect merged commit 55694ba into rubygems:1-0-stable May 27, 2011
@indirect
Copy link
Member

definitely better, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants