This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Don't allow to use bundler/capistrano with cap 3.x #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,9 @@ | |||
| # Bundler will be activated after each new deployment. | |||
| require 'bundler/deployment' | |||
|
|
|||
| if Gem::Version.new(Capistrano::Version).release < Gem::Version.new("3.0") | |||
| raise StandardError.new("For Capistrano 3.x integration, please check http://github.com/capistrano/bundler") | |||
There was a problem hiding this comment.
Why is this StandardError instead of the default RuntimeError?
|
Great idea. |
|
@xaviershay fixed! |
| @@ -4,6 +4,10 @@ | |||
| # Bundler will be activated after each new deployment. | |||
| require 'bundler/deployment' | |||
|
|
|||
| if Gem::Version.new(Capistrano::Version).release < Gem::Version.new("3.0") | |||
| raise RuntimeError.new("For Capistrano 3.x integration, please use http://github.com/capistrano/bundler") | |||
There was a problem hiding this comment.
sorry I wasn't clear, now this is equivalent to: raise "For Cap 3...", no need to reference RuntimeError explicitly.
|
@xaviershay fixed! |
| @@ -4,6 +4,10 @@ | |||
| # Bundler will be activated after each new deployment. | |||
| require 'bundler/deployment' | |||
|
|
|||
| if Gem::Version.new(Capistrano::Version).release < Gem::Version.new("3.0") | |||
There was a problem hiding this comment.
wait, shouldn't this conditional be the other way around? Didn't see that before.
CapVersion >= 3?
|
@xaviershay sorry, my fault. Fixed |
|
Merged, thanks! |
|
(build breakage is transient) |
xaviershay
added a commit
that referenced
this pull request
Aug 16, 2013
Don't allow to use bundler/capistrano with cap 3.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capistrano 3.x has separate gem for bundler integration (capistrano/bundler) and I think it would be useful to stop Capistrano 3.x users from requiring this task.