This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Allow Bundler::RubyVersion to handle -1 for RUBY_PATCHLEVEL
#4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RochesterinNYC
changed the title
Bundler::RubyVersion to handle -1 for RUBY_PATCHLEVELBundler::RubyVersion to handle -1 for RUBY_PATCHLEVEL
|
Updated this PR with the actual non-WIP fix. Build for ruby-head and rubygems master passes now. |
|
👍🏻 |
|
@homu r+ |
|
📌 Commit 483bd8e has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Feb 27, 2016
…-patchlevel-handling, r=indirect Allow `Bundler::RubyVersion` to handle -1 for RUBY_PATCHLEVEL Fixes how the `matches?` method in `Bundler::RubyVersion` handles a `RUBY_PATCHLEVEL` of `-1`, which seems to be the case with ruby-head. Closes #4317
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes how the
matches?method inBundler::RubyVersionhandles aRUBY_PATCHLEVELof-1, which seems to be the case with ruby-head.Closes #4317