Add machinery for printing major deprecations #4702
Conversation
| major_deprecation("Bundler will only support ruby >= 2.0, you are running #{RUBY_VERSION}") | ||
| end | ||
| return if Bundler.rubygems.provides?(">= 2") | ||
| major_deprecation("Bundler will only support rubygems >= 2.4, you are running #{self.class.version}") |
There was a problem hiding this comment.
I thought we said RubyGems 2.0 and above?
|
@indirect r? |
|
@homu r+ |
|
📌 Commit 53737e0 has been approved by |
Add machinery for printing major deprecations First step towards handling all of #4695 \c @RochesterinNYC @indirect
|
💔 Test failed - status |
Will make future diffs much easier to read
segiddins
force-pushed
the
seg-major-deprecations
branch
from
53737e0
to
2cc7c46
Compare
|
📌 Commit 2cc7c46 has been approved by |
|
@homu r=indirect |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit 2cc7c46 has been approved by |
|
💡 This pull request was already approved, no need to approve it again. |
|
⚡ Test exempted - status |
Add machinery for printing major deprecations First step towards handling all of #4695 \c @RochesterinNYC @indirect
Add machinery for printing major deprecations First step towards handling all of #4695 \c @RochesterinNYC @indirect (cherry picked from commit dca6d26)
|
Please reconsider removing clean_env ... it's not a nice api and has known drawbacks, but forcing others to re-implement it is not helping either. |
|
@grosser why would you not use original_env instead? |
|
because it still includes BUNDLE_GEMFILE / RUBYLIB etc |
|
|
|
the more common case would be |
|
Ugh, that seems like a bug. :/ I agree that we should either fix original_env to provide access to the pre-bundler env or keep clean_env, though. |
|
agreed! |
|
@grosser please open a new issue to discuss this! This PR was merged a year ago and was simply porting things that were implemented on the 1-99-dev branch before |
First step towards handling all of #4695
\c @RochesterinNYC @indirect