Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Documentation and error improvements #5168

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/bundler/cli/install.rb
Expand Up @@ -57,7 +57,7 @@ def run

if options["binstubs"]
Bundler::SharedHelpers.major_deprecation \
"the --binstubs option will be removed in favor of `bundle binstubs`"
"The --binstubs option will be removed in favor of `bundle binstubs`"
end

Plugin.gemfile_install(Bundler.default_gemfile) if Bundler.feature_flag.plugins?
Expand Down Expand Up @@ -167,8 +167,8 @@ def check_for_group_conflicts
def check_for_options_conflicts
if (options[:path] || options[:deployment]) && options[:system]
error_message = String.new
error_message << "You have specified both a path to install your gems to as well as --system. Please choose.\n" if options[:path]
error_message << "You have specified both --deployment as well as --system. Please choose.\n" if options[:deployment]
error_message << "You have specified both --path as well as --system. Please choose only one option.\n" if options[:path]
error_message << "You have specified both --deployment as well as --system. Please choose only one option.\n" if options[:deployment]
raise InvalidOption.new(error_message)
end
end
Expand Down
4 changes: 2 additions & 2 deletions man/bundle.ronn
Expand Up @@ -73,10 +73,10 @@ We divide `bundle` subcommands into primary commands and utilities.
* `bundle init(1)`:
Generate a simple `Gemfile`, placed in the current directory

* [bundle gem(1)][bundle-gem]:
* [`bundle gem(1)`][bundle-gem]:
Create a simple gem, suitable for development with bundler

* [bundle platform(1)][bundle-platform]:
* [`bundle platform(1)`][bundle-platform]:
Display platform compatibility information

* `bundle clean(1)`:
Expand Down
8 changes: 4 additions & 4 deletions spec/install/deploy_spec.rb
Expand Up @@ -22,15 +22,15 @@
it "disallows --deployment --system" do
bundle "install --deployment --system"
expect(out).to include("You have specified both --deployment")
expect(out).to include("Please choose.")
expect(out).to include("Please choose only one option")
expect(exitstatus).to eq(15) if exitstatus
end

it "disallows --deployment --path --system" do
bundle "install --deployment --path . --system"
expect(out).to include("You have specified both a path to install your gems to")
expect(out).to include("You have specified both --deployment")
expect(out).to include("Please choose.")
expect(out).to include("You have specified both --path")
expect(out).to include("as well as --system")
expect(out).to include("Please choose only one option")
expect(exitstatus).to eq(15) if exitstatus
end

Expand Down
2 changes: 1 addition & 1 deletion spec/install/path_spec.rb
Expand Up @@ -38,7 +38,7 @@

it "disallows --path vendor/bundle --system" do
bundle "install --path vendor/bundle --system"
expect(out).to include("Please choose.")
expect(out).to include("Please choose only one option.")
expect(exitstatus).to eq(15) if exitstatus
end

Expand Down
2 changes: 1 addition & 1 deletion spec/other/major_deprecation_spec.rb
Expand Up @@ -97,7 +97,7 @@
G

bundle :install, :binstubs => true
expect(warnings).to have_major_deprecation a_string_including("the --binstubs option will be removed")
expect(warnings).to have_major_deprecation a_string_including("The --binstubs option will be removed")
end
end
end
Expand Down