Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

[Definition] Fail when installing in frozen mode & gemspec deps have changed #5266

Merged
merged 7 commits into from Feb 12, 2017
Merged

[Definition] Fail when installing in frozen mode & gemspec deps have changed #5266

merged 7 commits into from Feb 12, 2017

Conversation

segiddins
Copy link
Member

@segiddins segiddins commented Dec 20, 2016 •
edited

Closes #5264

  • Specs

@segiddins segiddins force-pushed the seg-install-frozen-gemspec-deps-changed branch from 5e4fa53 to 18df139 Compare December 21, 2016 16:59
@olleolleolle
Copy link
Member

I got interested in this test failure.

Can this be it?

Bundler::ParallelInstaller::SpecInstallation now needs to forward #full_name to its @spec's #full_name:

def full_name
  @spec.full_name
end

Here's a Specification with #full_name: https://github.com/bundler/bundler/blob/master/lib/bundler/remote_specification.rb

@bundlerbot
Copy link
Collaborator

☔ The latest upstream changes (presumably #5267) made this pull request unmergeable. Please resolve the merge conflicts.

@segiddins segiddins force-pushed the seg-install-frozen-gemspec-deps-changed branch from 18df139 to 5e171e3 Compare February 10, 2017 18:45
@segiddins
Copy link
Member Author

Rebased and added a spec, but this is still breaking something existing in the deploy spec

@segiddins
Copy link
Member Author

Wahoo, this should finally work! Please carefully review the changes to Path -- they're the only thing I'm scared of here, @indirect .

@indirect
Copy link
Member

These changes look pretty reasonable to me. With passing tests, I'm r+ on this.

@segiddins
Copy link
Member Author

@bundlerbot r=indirect

@bundlerbot
Copy link
Collaborator

📌 Commit 11eb4ec has been approved by indirect

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 11eb4ec with merge cb73a5c...

bundlerbot added a commit that referenced this pull request Feb 12, 2017
@bundlerbot
Auto merge of #5266 - bundler:seg-install-frozen-gemspec-deps-changed…
cb73a5c 
…, r=indirect

[Definition] Fail when installing in frozen mode & gemspec deps have changed

Closes #5264

- [x] Specs
@segiddins segiddins added this to the 1.14.5 milestone Feb 12, 2017
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: indirect
Pushing cb73a5c to master...

@bundlerbot bundlerbot merged commit 11eb4ec into master Feb 12, 2017
@segiddins segiddins deleted the seg-install-frozen-gemspec-deps-changed branch February 16, 2017 05:59
segiddins pushed a commit that referenced this pull request Feb 22, 2017
@bundlerbot @segiddins
Auto merge of #5266 - bundler:seg-install-frozen-gemspec-deps-changed…
ef7f81e 
…, r=indirect

[Definition] Fail when installing in frozen mode & gemspec deps have changed

Closes #5264

- [x] Specs

(cherry picked from commit cb73a5c)
@segiddins segiddins mentioned this pull request Apr 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@indirect indirect Awaiting requested review from indirect

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@segiddins @olleolleolle @bundlerbot @indirect