This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[ParallelInstaller] Do not deadlock when the lockfile is missing dependencies entirely #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice work 👍 @bundlerbot r+ |
|
📌 Commit eefb983 has been approved by |
segiddins
commented
Mar 15, 2017
|
|
||
| fatally_missing_specs = missing_dependencies.map(&:last).flatten.map(&:name) - @specs.map(&:name) | ||
| return Bundler.ui.warning(warning) if fatally_missing_specs.empty? | ||
| raise InstallError, warning.concat("\n\nBundler is unable to continue installing without #{fatal.join(",")} in the lockfile.") |
There was a problem hiding this comment.
use the proper var, fatally_missing_specs
bundlerbot
added a commit
that referenced
this pull request
Mar 15, 2017
…ndirect [ParallelInstaller] Do not deadlock when the lockfile is missing dependencies entirely Closes #5480
|
💔 Test failed - status-travis |
This was referenced Mar 23, 2017
|
@segiddins ping |
|
I've not forgotten about this, just haven't come up with a good way to actually fix it yet 😔 |
|
Ping? Any updates on this? Still running into deadlocks unfortunately. 😢 In my case, removing |
|
I'll update this PR as soon as progress is made -- I haven't figured out how it should work yet. |
|
Facing the same problem right now. Do you have any on news on this? Thx & Cheers. EDIT: |
|
@zirni try bundler v1.15.0.pre.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5480
Closes #5519