Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

bundler gem: Support test-unit as a testing framework #5521

Merged
1 commit merged into from
Jan 8, 2020

Conversation

kou
Copy link
Contributor

@kou kou commented Mar 17, 2017

No description provided.

@kou
Copy link
Contributor Author

kou commented Mar 17, 2017

Sorry. I missed #5255 .

@mame
Copy link
Contributor

mame commented Dec 9, 2019

I believe that this PR is accepted. See #7420 and #7421.

@hsbt hsbt reopened this Dec 9, 2019
@hsbt
Copy link
Member

hsbt commented Dec 9, 2019

@kou Can you rebase this?

@kou
Copy link
Contributor Author

kou commented Dec 9, 2019

Sure. I'll do it.

@kou kou force-pushed the newgem-support-test-unit branch 3 times, most recently from bff5f34 to 2913841 Compare December 11, 2019 06:54
@kou
Copy link
Contributor Author

kou commented Dec 11, 2019

Done.
Some improvements in #7420 are also included.

@hsbt
Copy link
Member

hsbt commented Jan 8, 2020

@bundlerbot merge

ghost pushed a commit that referenced this pull request Jan 8, 2020
5521: bundler gem: Support test-unit as a testing framework r=hsbt a=kou



Co-authored-by: Kouhei Sutou <kou@clear-code.com>
@hsbt
Copy link
Member

hsbt commented Jan 8, 2020

@bundlerbot retry

@ghost
Copy link

ghost commented Jan 8, 2020

Already running a review

@ghost
Copy link

ghost commented Jan 8, 2020

Build succeeded

@ghost ghost merged commit 27f5e98 into rubygems:master Jan 8, 2020
@kou kou deleted the newgem-support-test-unit branch January 8, 2020 09:18
@hsbt
Copy link
Member

hsbt commented Jan 8, 2020

@deivid-rodriguez test-unit was shipped with the ruby-core installer. So, It's the same situation as minitest. If an issue related to this was found, I or @kou will fix it.

@deivid-rodriguez
Copy link
Member

Great! ❤️

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants