This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Installer] Load plugin files from path gems #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
commented
Jun 4, 2017
lib/bundler/installer.rb
Outdated
|
|
||
| requested_path_gems = @definition.requested_specs.select {|s| s.source.is_a?(Source::Path) } | ||
| path_plugin_files = requested_path_gems.map do |spec| | ||
| spec.matches_for_glob("rubygems_plugin#{Bundler.rubygems.suffix_pattern}") |
segiddins
force-pushed
the
seg-load-path-gem-plugins
branch
from
21de225
to
080f134
Compare
|
This ought to pass now |
segiddins
force-pushed
the
seg-load-path-gem-plugins
branch
from
080f134
to
ce0bf59
Compare
|
Fixed |
|
@bundlerbot r+ |
|
📌 Commit ce0bf59 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 15, 2017
[Installer] Load plugin files from path gems Closes #5429 . Because RubyGems doesn't know about path gems before we install, we need to manually load the plugin files for the path gems we're installing. This is basically copying the logic RG uses, but scoped only to those gems that we're entirely responsible for.
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5429 .
Because RubyGems doesn't know about path gems before we install, we need to manually load the plugin files for the path gems we're installing. This is basically copying the logic RG uses, but scoped only to those gems that we're entirely responsible for.