This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add a spec for installing git deps after packaging without git #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
seg-package-install-no-git
branch
3 times, most recently
from
8e2ba66
to
346ed3b
Compare
deivid-rodriguez
force-pushed
the
seg-package-install-no-git
branch
from
346ed3b
to
3442348
Compare
|
I rebased this one and it's passing, so I guess there's no harm on merging it. |
deivid-rodriguez
force-pushed
the
seg-package-install-no-git
branch
from
3442348
to
65351c5
Compare
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Aug 27, 2019
6112: Add a spec for installing git deps after packaging without git r=deivid-rodriguez a=segiddins ### What was the end-user problem that led to this PR? The problem was v1.15 seemed to break installing without git when the git deps had already been packaged (see #6066). ### What was your diagnosis of the problem? My diagnosis was we actually seemed to have fixed this for 1.16. ### What is your fix for the problem, implemented in this PR? My fix adds a test to ensure we won't regress. Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was v1.15 seemed to break installing without git when the git deps had already been packaged (see #6066).
What was your diagnosis of the problem?
My diagnosis was we actually seemed to have fixed this for 1.16.
What is your fix for the problem, implemented in this PR?
My fix adds a test to ensure we won't regress.