This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Rename Bundler.frozen? to avoid Object method conflict #6257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bundlerbot r+ |
|
📌 Commit 59d21d5 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jan 16, 2018
Rename Bundler.frozen? to avoid Object method conflict ### What was the end-user problem that led to this PR? The problem was `Bundler` overrode the `Object#frozen?` method to mean something else, breaking anything that checks that method to determine if an object is frozen. Closes #6252. ### What was your diagnosis of the problem? My diagnosis was the method name had to be changed.
|
☀️ Test successful - status-travis |
colby-swandale
pushed a commit
that referenced
this pull request
Apr 11, 2018
Rename Bundler.frozen? to avoid Object method conflict ### What was the end-user problem that led to this PR? The problem was `Bundler` overrode the `Object#frozen?` method to mean something else, breaking anything that checks that method to determine if an object is frozen. Closes #6252. ### What was your diagnosis of the problem? My diagnosis was the method name had to be changed. (cherry picked from commit 2c05914)
colby-swandale
pushed a commit
that referenced
this pull request
Apr 20, 2018
Rename Bundler.frozen? to avoid Object method conflict ### What was the end-user problem that led to this PR? The problem was `Bundler` overrode the `Object#frozen?` method to mean something else, breaking anything that checks that method to determine if an object is frozen. Closes #6252. ### What was your diagnosis of the problem? My diagnosis was the method name had to be changed. (cherry picked from commit 2c05914)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was
Bundleroverrode theObject#frozen?method to mean something else, breaking anything that checks that method to determine if an object is frozen.Closes #6252.
What was your diagnosis of the problem?
My diagnosis was the method name had to be changed.