This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Fix bundle gem generating unparsable ruby
#6304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in rubygems#6267.
deivid-rodriguez
changed the title
bundle gem generating unparsable ruby
|
Nice catch! Thanks! @bundlerbot r+ |
|
📌 Commit 9a83283 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Feb 22, 2018
…r=colby-swandale Fix `bundle gem` generating unparsable ruby ### What was the end-user problem that led to this PR? The problem was that the main file in a gem generated by `bundle gem` can't be inspected via `rubocop`. ### What was your diagnosis of the problem? My diagnosis was `bundler` was generating unparsable ruby in the generated gem. ### What is your fix for the problem, implemented in this PR? My fix was to change the offending template to generate valid ruby code. ### Why did you choose this fix out of the possible options? I chose this fix because it's the only one, really.
|
☀️ Test successful - status-travis |
|
Thanks @colby-swandale! |
colby-swandale
pushed a commit
that referenced
this pull request
Sep 20, 2018
…r=colby-swandale Fix `bundle gem` generating unparsable ruby ### What was the end-user problem that led to this PR? The problem was that the main file in a gem generated by `bundle gem` can't be inspected via `rubocop`. ### What was your diagnosis of the problem? My diagnosis was `bundler` was generating unparsable ruby in the generated gem. ### What is your fix for the problem, implemented in this PR? My fix was to change the offending template to generate valid ruby code. ### Why did you choose this fix out of the possible options? I chose this fix because it's the only one, really. (cherry picked from commit 3d82585)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
…r=colby-swandale Fix `bundle gem` generating unparsable ruby ### What was the end-user problem that led to this PR? The problem was that the main file in a gem generated by `bundle gem` can't be inspected via `rubocop`. ### What was your diagnosis of the problem? My diagnosis was `bundler` was generating unparsable ruby in the generated gem. ### What is your fix for the problem, implemented in this PR? My fix was to change the offending template to generate valid ruby code. ### Why did you choose this fix out of the possible options? I chose this fix because it's the only one, really. (cherry picked from commit 3d82585)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that the main file in a gem generated by
bundle gemcan't be inspected viarubocop.What was your diagnosis of the problem?
My diagnosis was
bundlerwas generating unparsable ruby in the generated gem.What is your fix for the problem, implemented in this PR?
My fix was to change the offending template to generate valid ruby code.
Why did you choose this fix out of the possible options?
I chose this fix because it's the only one, really.