Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Fix source_location call in PR 6237 and commit fbb1ff7 #6323

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fix source_location call in PR 6237 and commit fbb1ff7 #6323

merged 1 commit into from
Mar 5, 2018

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Mar 4, 2018 •
edited
Loading

Thanks to @nobu for pointing out the error (which was mine). source_location returns an array, not a string.

@MSP-Greg
Fix error in PR 6237 and commit fbb1ff7
f9f61d6 
Thanks to @nobu for pointing out the error.
@ghost
Copy link

ghost commented Mar 4, 2018

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

MSP-Greg referenced this pull request Mar 4, 2018
@MSP-Greg
Fix warning in rubygems testing re __FILE__
fbb1ff7
@hsbt
Copy link
Member

hsbt commented Mar 5, 2018

Thanks.

@hsbt
Copy link
Member

hsbt commented Mar 5, 2018

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit f9f61d6 has been approved by hsbt

@hsbt hsbt added this to the 1.16.2 milestone Mar 5, 2018
@bundlerbot
Copy link
Collaborator

⌛ Testing commit f9f61d6 with merge ffe58a3...

bundlerbot added a commit that referenced this pull request Mar 5, 2018
@bundlerbot
Auto merge of #6323 - MSP-Greg:fix_fbb1ff7_pr6237, r=hsbt
ffe58a3 
Fix source_location call in PR 6237 and commit fbb1ff7

Thanks to @nobu for pointing out the error (which was mine).  `source_location` returns an array, not a string.
@bundlerbot
Copy link
Collaborator

💔 Test failed - status-travis

@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: hsbt
Pushing ffe58a3 to master...

@bundlerbot bundlerbot merged commit f9f61d6 into rubygems:master Mar 5, 2018
@MSP-Greg MSP-Greg deleted the fix_fbb1ff7_pr6237 branch March 7, 2018 15:59
colby-swandale pushed a commit that referenced this pull request Apr 11, 2018
@bundlerbot @colby-swandale
Auto merge of #6323 - MSP-Greg:fix_fbb1ff7_pr6237, r=hsbt
e9ca381 
Fix source_location call in PR 6237 and commit fbb1ff7

Thanks to @nobu for pointing out the error (which was mine).  `source_location` returns an array, not a string.

(cherry picked from commit ffe58a3)
colby-swandale pushed a commit that referenced this pull request Apr 20, 2018
@bundlerbot @colby-swandale
Auto merge of #6323 - MSP-Greg:fix_fbb1ff7_pr6237, r=hsbt
aa133da 
Fix source_location call in PR 6237 and commit fbb1ff7

Thanks to @nobu for pointing out the error (which was mine).  `source_location` returns an array, not a string.

(cherry picked from commit ffe58a3)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MSP-Greg @hsbt @bundlerbot