-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
470d7de
to
551e8f6
Compare
@segiddins I am not able to test static gemfile option, do not know how to call it from Gemfile like you said. Can you please help me here? And how shall I proceed with this PR? |
|
Hello! I really like this feature. I went thru code and I have 2 initial questions. Sorry if they were answered already, but I can't find any previous discussion related to those questions.
|
c17cd72
to
f9e82e2
Compare
MD5 is quicker |
d240a2a
to
400e3d3
Compare
8bfab55
to
18374bc
Compare
18374bc
to
4a0c1e9
Compare
@segiddins context "with a current version" do
let(:base_version) { Gem::Version.create(Bundler::VERSION) }
it "returns an empty array" do
expect(subject).to eq([])
end
end We have added sections in |
The lockfile parser hash of known sections would need an update |
I didn't quite understand how to proceed. Should we not change |
What was the end-user problem that led to this PR?
The main aim is to reduce Gemfile resolve time if checksum remains same.
What was your diagnosis of the problem?
Add a section
CHECKSUMS
to lockfile that will store the checksum and will be used to match for future.I continued the work done by @segiddins.
What is your fix for the problem, implemented in this PR?
The main approach was to store a checksum of current gemfile under
CHECKSUMS
sections inGemfile.lock
In continuation of #5584.