Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add --skip-install flag to bundle add #6517

Merged
merged 2 commits into from May 20, 2018

Conversation

agrim123
Copy link
Contributor

@agrim123 agrim123 commented May 2, 2018

Usage

bundle add rack --skip-install

This flag would not install the gem, only add it to the gemfile.

Closes #6511

@agrim123 agrim123 force-pushed the agr-bundler-add-skip-install branch from b9c91d9 to c8f9836 Compare May 2, 2018 11:39
@@ -333,7 +333,8 @@ def binstubs(*gems)
method_option "version", :aliases => "-v", :type => :string
method_option "group", :aliases => "-g", :type => :string
method_option "source", :aliases => "-s", :type => :string

method_option "skip-install", :type => :boolean, :banner =>
"Adds gem to gemfile but does not install it"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition! ♥️ 💛 💚 💙 💜

Suggestion: harmonize wording with the rest of the options: to gemfile => to the Gemfile. (In this file and and in the .ronn documentation.)

@agrim123 agrim123 force-pushed the agr-bundler-add-skip-install branch from c8f9836 to dddfcf2 Compare May 14, 2018 13:19
@colby-swandale colby-swandale added this to the 1.17.0 milestone May 20, 2018
@colby-swandale
Copy link
Member

Thanks! @bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit dddfcf2 has been approved by colby-swandale

@bundlerbot
Copy link
Collaborator

⌛ Testing commit dddfcf2 with merge c793c38...

bundlerbot added a commit that referenced this pull request May 20, 2018
…swandale

Add --skip-install flag to bundle add

Usage
```bash
bundle add rack --skip-install
```
This flag would not install the gem, only add it to the gemfile.

Closes #6511
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing c793c38 to master...

@bundlerbot bundlerbot merged commit dddfcf2 into rubygems:master May 20, 2018
@agrim123 agrim123 deleted the agr-bundler-add-skip-install branch May 20, 2018 11:44
colby-swandale pushed a commit that referenced this pull request Sep 21, 2018
…swandale

Add --skip-install flag to bundle add

Usage
```bash
bundle add rack --skip-install
```
This flag would not install the gem, only add it to the gemfile.

Closes #6511

(cherry picked from commit c793c38)
colby-swandale pushed a commit that referenced this pull request Sep 22, 2018
…swandale

Add --skip-install flag to bundle add

Usage
```bash
bundle add rack --skip-install
```
This flag would not install the gem, only add it to the gemfile.

Closes #6511

(cherry picked from commit c793c38)
colby-swandale pushed a commit that referenced this pull request Oct 5, 2018
…swandale

Add --skip-install flag to bundle add

Usage
```bash
bundle add rack --skip-install
```
This flag would not install the gem, only add it to the gemfile.

Closes #6511

(cherry picked from commit c793c38)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants