Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Bump rubocop to 0.68.0 #7151

Merged
1 commit merged into from Apr 30, 2019
Merged

Bump rubocop to 0.68.0 #7151

1 commit merged into from Apr 30, 2019

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was that our rubocop version is getting outdated. Also, I added a PR to rubocop so that we can remove the exclusions in our configuration, and it has now been released.

What is your fix for the problem, implemented in this PR?

My fix is to update rubocop to the latest version, update the configuration, and fix new offenses.

@hsbt
Copy link
Member

hsbt commented Apr 30, 2019

👍

@hsbt
Copy link
Member

hsbt commented Apr 30, 2019

@bundlerbot r+

ghost pushed a commit that referenced this pull request Apr 30, 2019
7151: Bump rubocop to 0.68.0 r=hsbt a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that our rubocop version is getting outdated. Also, I added [a PR to rubocop](rubocop/rubocop#6935) so that we can remove the exclusions in our configuration, and it has now been released.

### What is your fix for the problem, implemented in this PR?

My fix is to update rubocop to the latest version, update the configuration, and fix new offenses.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Apr 30, 2019

Build succeeded

@ghost ghost merged commit bb45625 into master Apr 30, 2019
@ghost ghost deleted the rubocop_0_68 branch April 30, 2019 14:37
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants