This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION #7275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2019
eregon
force-pushed
the
always-use-RUBY_ENGINE_VERSION
branch
from
cd0bd0b
to
f3cc34c
Compare
* RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION.
eregon
force-pushed
the
always-use-RUBY_ENGINE_VERSION
branch
from
f3cc34c
to
f9d9104
Compare
|
Should be green now. |
|
https://travis-ci.org/bundler/bundler/jobs/567570729 failed but it seems transient and unrelated. |
|
Yup, this is the current annoying flaky we have in master. I'll work on fixing it tomorrow, but this PR is good to go for me! Thanks for improving this 👍. |
ghost
pushed a commit
to rubygems/rubygems
that referenced
this pull request
Aug 5, 2019
2864: Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION r=bronzdoc a=eregon * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION. This blocks #2797. Also see rubygems/bundler#7275 I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Benoit Daloze <eregontp@gmail.com>
|
Could we merge this PR? The related PR in RubyGems was merged. |
|
It will be merged soon, no worries. I just want to get master's build stable first. |
|
It should be good now. Thanks so much for this @eregon! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Aug 5, 2019
7275: Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION r=deivid-rodriguez a=eregon * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION. This blocks rubygems/rubygems#2797. Also see rubygems/rubygems#2864 Co-authored-by: Benoit Daloze <eregontp@gmail.com>
Build succeeded |
ghost
merged commit
|
@deivid-rodriguez Thanks for merging! |
hsbt
pushed a commit
to rubygems/rubygems
that referenced
this pull request
Aug 16, 2019
2864: Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION r=bronzdoc a=eregon * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION. This blocks #2797. Also see rubygems/bundler#7275 I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Benoit Daloze <eregontp@gmail.com>
hsbt
pushed a commit
to rubygems/rubygems
that referenced
this pull request
Aug 16, 2019
2864: Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSION r=bronzdoc a=eregon * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION. This blocks #2797. Also see rubygems/bundler#7275 I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Benoit Daloze <eregontp@gmail.com>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks rubygems/rubygems#2797.
Also see rubygems/rubygems#2864