Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Suppress Warning: no department given for MutableConstant #7386

Conversation

koic
Copy link
Contributor

@koic koic commented Oct 20, 2019

This PR suppresses the following Warning: no department given for MutableConstant.

% cd path/to/bundler
% bundle exec rubocop -v
0.75.1
% bundle exec rubocop --parallel
(snip)

/Users/koic/src/github.com/bundler/bundler/lib/bundler/gem_helpers.rb:
Warning: no department given for MutableConstant. Run `rubocop -a --only
Migration/DepartmentName` to fix.

This PR suppresses the following `Warning: no department given for MutableConstant`.

```console
% cd path/to/bundler
% bundle exec rubocop -v
0.75.1
% bundle exec rubocop --parallel
(snip)

/Users/koic/src/github.com/bundler/bundler/lib/bundler/gem_helpers.rb:
Warning: no department given for MutableConstant. Run `rubocop -a --only
Migration/DepartmentName` to fix.
```
@colby-swandale
Copy link
Member

Thanks! @bundlerbot r+

@colby-swandale
Copy link
Member

@bundlerbot r+

ghost pushed a commit that referenced this pull request Oct 21, 2019
7386: Suppress `Warning: no department given for MutableConstant` r=colby-swandale a=koic

This PR suppresses the following `Warning: no department given for MutableConstant`.

```console
% cd path/to/bundler
% bundle exec rubocop -v
0.75.1
% bundle exec rubocop --parallel
(snip)

/Users/koic/src/github.com/bundler/bundler/lib/bundler/gem_helpers.rb:
Warning: no department given for MutableConstant. Run `rubocop -a --only
Migration/DepartmentName` to fix.
```



Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@ghost
Copy link

ghost commented Oct 21, 2019

Timed out

@deivid-rodriguez
Copy link
Member

@bundlerbot r=colby-swandale

@deivid-rodriguez
Copy link
Member

@bundlerbot retry

ghost pushed a commit that referenced this pull request Oct 22, 2019
7386: Suppress `Warning: no department given for MutableConstant` r=colby-swandale a=koic

This PR suppresses the following `Warning: no department given for MutableConstant`.

```console
% cd path/to/bundler
% bundle exec rubocop -v
0.75.1
% bundle exec rubocop --parallel
(snip)

/Users/koic/src/github.com/bundler/bundler/lib/bundler/gem_helpers.rb:
Warning: no department given for MutableConstant. Run `rubocop -a --only
Migration/DepartmentName` to fix.
```



Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@ghost
Copy link

ghost commented Oct 22, 2019

Build succeeded

@ghost ghost merged commit 102df2d into rubygems:master Oct 22, 2019
@koic koic deleted the suppress_warning_no_department_given_for_mutable_constant branch October 22, 2019 11:54
@deivid-rodriguez deivid-rodriguez added this to the 2.1.0.pre.3 milestone Nov 6, 2019
deivid-rodriguez pushed a commit that referenced this pull request Nov 7, 2019
7386: Suppress `Warning: no department given for MutableConstant` r=colby-swandale a=koic

This PR suppresses the following `Warning: no department given for MutableConstant`.

```console
% cd path/to/bundler
% bundle exec rubocop -v
0.75.1
% bundle exec rubocop --parallel
(snip)

/Users/koic/src/github.com/bundler/bundler/lib/bundler/gem_helpers.rb:
Warning: no department given for MutableConstant. Run `rubocop -a --only
Migration/DepartmentName` to fix.
```

Co-authored-by: Koichi ITO <koic.ito@gmail.com>
(cherry picked from commit bb6edfa)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants