Skip to content
This repository has been archived by the owner. It is now read-only.

Delegate should be supported now #7483

Merged
1 commit merged into from Dec 14, 2019
Merged

Delegate should be supported now #7483

1 commit merged into from Dec 14, 2019

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Dec 14, 2019

What was the end-user problem that led to this PR?

The problem was that delegate is now supported since did_you_mean drop its dependency on it at ruby/ruby@e270806.

What was your diagnosis of the problem?

My diagnosis was that we can test that arbitrary delegate versions can be included in Gemfiles again.

What is your fix for the problem, implemented in this PR?

My fix removes delegate from the exemptions.

Since `did_you_mean` dropped its dependency on it.
@deivid-rodriguez deivid-rodriguez added this to the 2.1.0 milestone Dec 14, 2019
@deivid-rodriguez
Copy link
Member Author

deivid-rodriguez commented Dec 14, 2019

@bundlerbot merge

ghost pushed a commit that referenced this issue Dec 14, 2019
7483: Delegate should be supported now r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that delegate is now supported since `did_you_mean` drop its dependency on it at ruby/ruby@e270806.

### What was your diagnosis of the problem?

My diagnosis was that we can test that arbitrary `delegate` versions can be included in Gemfiles again.

### What is your fix for the problem, implemented in this PR?

My fix removes `delegate` from the exemptions.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
@ghost
Copy link

ghost commented Dec 14, 2019

Build succeeded

@ghost ghost merged commit 9c26878 into master Dec 14, 2019
3 checks passed
@ghost ghost deleted the delegate_is_now_supported branch Dec 14, 2019
deivid-rodriguez pushed a commit that referenced this issue Dec 15, 2019
7483: Delegate should be supported now r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that delegate is now supported since `did_you_mean` drop its dependency on it at ruby/ruby@e270806.

### What was your diagnosis of the problem?

My diagnosis was that we can test that arbitrary `delegate` versions can be included in Gemfiles again.

### What is your fix for the problem, implemented in this PR?

My fix removes `delegate` from the exemptions.

Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
(cherry picked from commit fc2b63c)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant