Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Adds documentation for BUNDLE_APP_CONFIG env var #7563

Merged
1 commit merged into from
Jan 16, 2020

Conversation

dchandekstark
Copy link
Contributor

@dchandekstark dchandekstark commented Jan 10, 2020

Fixes #7085

What was the end-user problem that led to this PR?

The problem was missing documentation.

What was your diagnosis of the problem?

N/A

What is your fix for the problem, implemented in this PR?

Provided some documentation.

Why did you choose this fix out of the possible options?

N/A

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about notation but looks good. If you can fix that, and rebase and squash your commits, that'd be great! Thanks so much for doing this! 💯

man/bundle-config.ronn Outdated Show resolved Hide resolved
@dchandekstark
Copy link
Contributor Author

@deivid-rodriguez Change accepted and commits squashed. Thanks!

@deivid-rodriguez
Copy link
Member

Thanks for adding these missing docs! 💜

@bundlerbot merge

ghost pushed a commit that referenced this pull request Jan 16, 2020
7563: Adds documentation for BUNDLE_APP_CONFIG env var r=deivid-rodriguez a=dchandekstark

Fixes #7085

### What was the end-user problem that led to this PR?

The problem was missing documentation.

### What was your diagnosis of the problem?

N/A

### What is your fix for the problem, implemented in this PR?

Provided some documentation.

### Why did you choose this fix out of the possible options?

N/A

Co-authored-by: David Chandek-Stark <david.chandek.stark@duke.edu>
@ghost
Copy link

ghost commented Jan 16, 2020

Build succeeded

@ghost ghost merged commit 798fb14 into rubygems:master Jan 16, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Where is a document for BUNDLE_APP_CONFIG?
2 participants