This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add support for BUNDLER_ prefixed debug environment variables #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEBUG_RESOLVER is used in RubyGems too. So we can't enable it only for Bundler.
colby-swandale
approved these changes
Jan 19, 2020
|
Thanks! 😍 @bundlerbot r=colby-swandale |
ghost
pushed a commit
that referenced
this pull request
Jan 19, 2020
7589: Add support for BUNDLER_ prefixed debug environment variables r=colby-swandale a=kou DEBUG_RESOLVER is used in RubyGems too. So we can't enable it only for Bundler. ### What was the end-user problem that led to this PR? The problem was not the end-user problem. It's a developer problem. ### What was your diagnosis of the problem? My diagnosis was RubyGems also uses `DEBUG_RESOLVER` environment variable. So we can't use `DEBUG_RESOLVER` environment variable to enable debug mode only for Bundler. We can use `DEBUG_RESOLVER_TREE` instead of `DEBUG_RESOLVER` only for `Bundler::Resolver`. But we can't do it for `Bundler::GemVersionPromoter`. ### What is your fix for the problem, implemented in this PR? My fix adds `BUNDLER_` prefix to `DEBUG_RESOLVER` and `DEBUG_RESOLVER_TREE` like other environment variables for Bundler such as `BUNDLER_EDITOR` do. ### Why did you choose this fix out of the possible options? I chose this fix because adding prefix is a common way. Bundlerd Molinillo and Thor also use this way such as `MOLINILLO_DEBUG` and `THOR_SHELL`. Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Build succeeded
|
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEBUG_RESOLVER is used in RubyGems too. So we can't enable it only for
Bundler.
What was the end-user problem that led to this PR?
The problem was not the end-user problem. It's a developer problem.
What was your diagnosis of the problem?
My diagnosis was RubyGems also uses
DEBUG_RESOLVERenvironment variable. So we can't useDEBUG_RESOLVERenvironment variable to enable debug mode only for Bundler. We can useDEBUG_RESOLVER_TREEinstead ofDEBUG_RESOLVERonly forBundler::Resolver. But we can't do it forBundler::GemVersionPromoter.What is your fix for the problem, implemented in this PR?
My fix adds
BUNDLER_prefix toDEBUG_RESOLVERandDEBUG_RESOLVER_TREElike other environment variables for Bundler such asBUNDLER_EDITORdo.Why did you choose this fix out of the possible options?
I chose this fix because adding prefix is a common way. Bundlerd Molinillo and Thor also use this way such as
MOLINILLO_DEBUGandTHOR_SHELL.