This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Prepend debug label to resolver's debug message #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have the same label in all resolver's debug messages, we can find resolver's debug message easily. For example, we can use "/BUNDLER:" in less. It's useful when we have many debug messages.
kou
force-pushed
the
resolver-debug-prefix
branch
from
d051aba
to
9e60772
Compare
|
@bundlerbot merge |
ghost
pushed a commit
that referenced
this pull request
Jan 22, 2020
7590: Prepend debug label to resolver's debug message r=deivid-rodriguez a=kou ### What was the end-user problem that led to this PR? The problem was not a end-user problem. This was a developer problem. If we have many debug messages (for example, I added many `pp [...]` to debug #7522), it's difficult to find resolver's debug messages. ### What was your diagnosis of the problem? My diagnosis was no common keywords in resolver's debug message is a problem. If we have a common keyword, we can find resolver's debug messages from many debug messages easily. ### What is your fix for the problem, implemented in this PR? My fix prepends `BUNDLER: ` to all resolver's debug messages. If we have the same label in all resolver's debug messages, we can find resolver's debug message easily. For example, we can use "/BUNDLER:" in less. ### Why did you choose this fix out of the possible options? I chose this fix because `BUNDLER: ` will not conflict. Other candidate is `DEBUG: ` but it may be used by other library. If the keyword conflicts, it's not easy to find resolver's debug messages. `Bundler::Resolver: ` will be more safer but it may be long. Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Build failed |
|
Hopefully the CI is a little more stable now. @bundlerbot merge |
Build succeeded
|
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was not a end-user problem. This was a developer problem.
If we have many debug messages (for example, I added many
pp [...]to debug #7522), it's difficult to find resolver's debug messages.What was your diagnosis of the problem?
My diagnosis was no common keywords in resolver's debug message is a problem. If we have a common keyword, we can find resolver's debug messages from many debug messages easily.
What is your fix for the problem, implemented in this PR?
My fix prepends
BUNDLER:to all resolver's debug messages. If we have the same label in all resolver's debug messages, we can find resolver's debug message easily. For example, we can use "/BUNDLER:" in less.Why did you choose this fix out of the possible options?
I chose this fix because
BUNDLER:will not conflict. Other candidate isDEBUG:but it may be used by other library. If the keyword conflicts, it's not easy to find resolver's debug messages.Bundler::Resolver:will be more safer but it may be long.