Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backends for Gemstash storage of private gems #242

Closed
wants to merge 8 commits into from

Conversation

gayashanbc
Copy link

@gayashanbc gayashanbc commented Jun 24, 2019

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo.

lib/gemstash/cli/setup.rb Outdated Show resolved Hide resolved
lib/gemstash/cli/setup.rb Outdated Show resolved Hide resolved
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the first bit of functionality of the S3 backend feature.

That's good and will become useful to a user when gemstash offers an s3 backend.

(How do we want to proceed with building this feature?)

@indirect
Copy link
Member

This is a good start! @gayashanbc, let's plan to continue adding commits to this PR, and we can give feedback and code review when you push or at least once a week. Once this PR has a more complete version of the backends feature, we can merge it.

@gayashanbc
Copy link
Author

aws-sdk is added to the Gemfile.
I have tested and verified the ability to verify the SDK using either of the following options.

  1. Default AWS credentials file (e.g. on Unix-like systems this file is located at ~/.aws/credentials)
  2. Using environmental the environmental variables AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY

Currently, I'm working on displaying an error message when the SDK is not authorized using either of the above methods and displaying a link to official AWS page where it shows how the AWS credentials can be configured on the system. This will be implemented in the trigger action, when the backend is selected as 's3'.

@gayashanbc
Copy link
Author

Above two commits implement the authorization trigger for s3 backend and the initial version of ask_s3_metadata method which checks if the given bucket_name already exists in AWS S3.

The next step is to create an S3 bucket using the given bucket_name if it does not exist already.

A new S3 bucket will be created when the specified bucket is not owned.
@gayashanbc
Copy link
Author

Update: Above commit implements support for creating a new S3 bucket when the specified bucket is not owned by the user. It will also display an error when specified bucket_name is already taken by another user.

@gayashanbc gayashanbc changed the title Implement support for the 'backend' property Add backends for Gemstash storage of private gems Jul 15, 2019
@bronzdoc
Copy link
Member

closing this since a s3 backend was added in #270 thanks!

@bronzdoc bronzdoc closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants