Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-reference.md - 'Options' parsing - CommonMark issue #233

Closed
MSP-Greg opened this issue May 1, 2019 · 2 comments
Closed

command-reference.md - 'Options' parsing - CommonMark issue #233

MSP-Greg opened this issue May 1, 2019 · 2 comments

Comments

@MSP-Greg
Copy link
Contributor

MSP-Greg commented May 1, 2019

I noticed this when I needed to reference:

https://msp-greg.github.io/ruby_trunk/rubygems/file.command-reference.html

I'm using the same md parser as GitHub (commonmarker), while rdoc uses it's own md parser. Not sure about Jekyll...

Anyway, check the options sections in:
https://github.com/rubygems/guides/blob/gh-pages/command-reference.md
vs:
https://github.com/MSP-Greg/guides/blob/md-commonmark/command-reference.md

The following line:

guides/Rakefile

Line 129 in 9bf5801

options += "* #{helpline}\n"

Changed to:

options += "* #{helpline.strip}\n"

fixes the issue.

@bronzdoc
Copy link
Member

bronzdoc commented May 1, 2019

Thanks @MSP-Greg! want to submit a PR for it?

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented May 1, 2019

@bronzdoc

Ok. See @234.

Would docs of RubyGems & Bundler masters be helpful? I always use the copies in Ruby trunk, but it's often behind the respective masters. Typically, I update once or twice a day...

@MSP-Greg MSP-Greg closed this as completed May 1, 2019
ghost pushed a commit that referenced this issue May 1, 2019
234: command-reference.md - fix md parsing in 'Options' r=bronzdoc a=MSP-Greg

See Issue #233

Co-authored-by: MSP-Greg <msp-greg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants