Use the new hooks to uninstall gems if they fail testing.

Bump the rubygems requirement to 1.5 to reflect above changes.
rubygems · Apr 17, 2011 · 441aa6f · 441aa6f
1 parent 4594942
commit 441aa6f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/Rakefile b/Rakefile
@@ -32,7 +32,7 @@ spec = Hoe.spec 'rubygems-test' do
   pluggable!
 
   require_ruby_version ">= 1.8.7"
-  require_rubygems_version ">= 1.3.6"
+  require_rubygems_version ">= 1.5.0"
 
   extra_deps << ['rake', '>= 0.8.7']
 

diff --git a/lib/rubygems/on_install_test.rb b/lib/rubygems/on_install_test.rb
@@ -3,7 +3,7 @@
 Gem.autoload(:RakeNotFoundError, 'exceptions')
 Gem.autoload(:TestError, 'exceptions')
 
-Gem.post_install do |gem|
+Gem.post_build do |gem|
   options = Gem.configuration["test_options"] || { }
 
   if options["auto_test_on_install"] or options["test_on_install"]
@@ -17,8 +17,7 @@
             options["force_uninstall_on_failure"] or
             gem.ui.ask_yes_no("Testing #{gem.spec.name} (#{gem.spec.version}) failed. Uninstall?", false)
 
-          # FIXME ask drbrain how to do this more better.
+            false
-          at_exit { Gem::Uninstaller.new(gem.spec.name, :version => gem.spec.version).uninstall }
         end
       end
     end

diff --git a/test/test_execute.rb b/test/test_execute.rb
@@ -81,5 +81,4 @@ def test_07_upload_results?
   ensure
     Gem.configuration.verbose = old_verbose
   end
-
 end