Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert single quotes back to double quotes #897

Closed
wants to merge 1 commit into from
Closed

Revert single quotes back to double quotes #897

wants to merge 1 commit into from

Conversation

jankeesvw
Copy link

When you look at the ruby style guide it says the following:

Adopt a consistent string literal quoting style. There are two popular styles in the Ruby community, both of which are considered good - single quotes by default and double quotes by default.

The second style is arguably a bit more popular in the Ruby community.

I think it's best to provide the most popular option as copy and paste.

@arthurnn
Copy link
Member

Yeah, I am ok with this, however want to see what other people think, as we dont want to keep moving back-and-forth with this.
this reverts https://github.com/jankeesvw/rubygems.org/commit/eec124a1d544fd2774020d1e49de7abdb04d1c0d by @garysweaver .

@indirect
Copy link
Member

I am a double-quoter, so I would prefer this. :P

On Thu, Feb 26, 2015 at 4:57 PM, Arthur Nogueira Neves
notifications@github.com wrote:

Yeah, I am ok with this, however want to see what other people think, as we dont want to keep moving back-and-forth with this.

this reverts https://github.com/jankeesvw/rubygems.org/commit/eec124a1d544fd2774020d1e49de7abdb04d1c0d by @garysweaver .

Reply to this email directly or view it on GitHub:
#897 (comment)

@dwradcliffe
Copy link
Member

More references: #660 #468

I would argue that single-quoted strings are more popular in recent years. The default for rails and rubocop is single quotes also. (And my personal preference.)

Clearly we aren't going to agree on this as a community.

@arthurnn
Copy link
Member

I am a double-quoter too, I would say this is a 50/50% thing. That said, I dont think we should spend time discussing or changing this.

thanks anyways for the PR.

@arthurnn arthurnn closed this Feb 27, 2015
@jankeesvw
Copy link
Author

Thanks for the responses, I like the point that it's the default in Rubocop! I agree with you on this. Thanks for the references @dwradcliffe, I didn't see those before.

Do you guys think this could be some kind of setting, in your account, by changing the url or something else? I use the copy-paste functionality quite often and it bothers me that I have to replace the quotes every time..

Ow and by the way, your development setup is amazing. I had the Rubygems site up and running in a few minutes. Great work. ✨

@NewAlexandria
Copy link

Double quotes follows the style of string interpolation, where single-quotes follows the style of literal strings. Though functional in this case, I would argue for consistencies that reduce ambiguity, both for advanced and entry-level coders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants