create a constant with pagination value

[lucianosousa]

avoid duplicated values in the controller

[nateberkopec]

👍 Is this value used anywhere else?

[lucianosousa]

Couldn't find it, but didn't look too deep.
I saw in a lot of places a pagination by 5 items.

[simi]

it is here also -

rubygems.org/app/controllers/rubygems_controller.rb

Line 14 in 0fcc8b0

@versions = Version.published(20)

(https://github.com/rubygems/rubygems.org/search?l=ruby&q=20&utf8=%E2%9C%93)

[lucianosousa]

Should we create a constant for this value in application.rb or any other place?

[farukaydin]

👎 on this. Although it's a kind of reducing duplication, it's not worth to change since we have different number of pagination and current version is sufficient enough to keep the codebase more readable.

Though, thanks for contributing rubygems.org 💙 ❤️

[sonalkr132]

I think this makes sense, we should have as few magic numbers as possible, even if it is only 2/3 fewer.

Should we create a constant for this value in application.rb

application.rb should be fine.

[lucianosousa]

Good.
I'll work on this still this week. ;)

[jvanbaarsen]

@lucianosousa Are you still working on this? If not, can you please close the PR? That way the list of open PRs is kept organised with active ones only :-)

[lucianosousa]

@jvanbaarsen sorry being late here Sir. It's done!

[jvanbaarsen]

@dwradcliffe I think this is ready to merge :-)

[sonalkr132]

@lucianosousa can you please squash your commits?

[sonalkr132]

Merged as f5686b3.

[lucianosousa]

cheers mates